Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • empyre empyre
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • empyreempyre
  • empyreempyre
  • Merge requests
  • !46

Fix clipping of rgb_from_vector()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Dieter Weber requested to merge weber/empyre:colorclipping into master Jul 29, 2022
  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 1
  • Clip saturation and luminance separately to make sure the result is clipped at the maximum possible saturation or luminance
  • Ensure that the argument of np.arccos(...) is within the allowed range to avoid NaN

Previously, clipping led to very strange colors in the result.

  • Evaluate how the result is changed in more use cases. Since there's no global R_max anymore, the automated "full range" will go to higher saturation values now, and luminance and saturation are no longer on the same scale but adjusted independently. This will probably lead to more contrast in plots where x, y and z have different ranges. It should be checked if the "color bar" and the display still match.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: colorclipping