GitLab

Note: This seems to have introduced some bugs. ...to be corrected soon.

The test failed because the unrotated input density was not kept for the mixer.
I solved it by introducing an inDenRot variable that is a copy of inDen and then
gets rotated in rhodirgen if that soubroutine is in the program flow. It is only
used as an input to those subroutines that require the rotated input density or
are insensitive to it.

Cleanup and bugfixes are required.

...still buggy and very incomplete.

The new test does not pass yet but it might already work.

fleur.F90 wannier call should put l_real=.false. also if l_soc is true; wannier.F allocations of zmat*%z_* should only be done one<- bug due to 110 spin loop

Note: Also in this commit:

1. Changed test values in NiO_ldauXML test since now the broyden files get deleted
   when a new density matrix is generated
2. The NiO_ldau test should not work any more since linear mixing for the density
   matrix is removed for the old inp file. (It is not specified in the n_mmp_mat
   file any more)

Note: Two changes have been done in global/types.F90:

   1. MERGE(jsp,4,l_noco) -> MERGE(4,jsp,l_noco)
      (I think the new code is correcter. This change is required)

   2. Some dimension variable was replaced by stars%ng2.
      (Maybe this is not required and maybe the previous variable was more correct.)

Up to now this is only a partial solution. There is still reading
of the n_mmp_mat file in the SCF loop to read in the optional mixing
parameters.

...also in this commit: global/constants.f -> global/constants.f90

I couldn't identify the original bug so I did some major changes and
now everything is different.

There still is a problem but it is different now.

Note: This seems to break the LDA+U part. I commit it at this point
to get it on a computer with Valgrind available.

...this is done to make gfortran with debug options happy.

...hope, it works.

-removing of variable icorr, use of member-functions instead
-removal of icorrkeys module
-removal of hybridmix module
-cleanup at several places