GitLab

Changes to mapping of k-points for transformation. Still not running as mapatom is not called before gen_bz.

Now fleur.F90 calls a subroutine that does most of the hybrid stuff.
In eigen.F90 only the non-local potential is added to the Hamiltonian

Introduced module types_rcmat with a general type for real/complex matrices
Introduced general IO for these matrices

valgrind reports that some uninitialized bytes are in a buffer to be written out to cdn.hdf.
The bytes surely are in that part of the buffer that does not contain relevant data. To me
The reported line for the error source is the close operation for the file. Therefore
it is not clear whether this originates from fleur or from HDF5. I can only identify that
this appeared while writing out the stars. Therefore I initialized every associated array
that did not seem to be initialized before setting the relevant elements to certain values.

I had to start valgrind with --num-callers=25 to see at least the fleur context for the
reported missing initializations.

This should not really be relevant. But I do everything my master valgrind tells me.

These initializations are relevant for the old inp file if no enpara file is used.

This commit is the first of probably several similar commits that adds
missing initializations found by valgrind.

Special thanks for this commit go to Aristid Breitkreuz and Christoph Dittmann
who pushed me to trying out valgrind.

The problem was that due to the removal of the CPP_APW compiler switch
there was no direct way to determine whether the APW codepath should
be used.

* The implicit assumption that the gamma point is the first k point was eliminated.
* The opening of the kpts file to determine the number of k points in the full BZ
  was eliminated (It is not yet tested if the new approach always works).
* Some variables have been removed, some have been renamed.
* Some debugging code has been removed.
* An error message was improved.

a) fixed CuDOSXML test
b) made compile with PGI
c) change testscript to work without "do"

- Relaxation of atom positions now works as it should.
- The code also becomes clearer.

- Relaxation of atom positions should work now, but it is not yet beautiful.
   -> An unnecessary additional step function is store in cdn.hdf in this case.

The elimination of the wkf2 file for cdn_hdf calculations
is not yet part of this commit.

...hope it doesn't break anything. HDF5 replacement of stars file
is not yet implemented.

...relevant if many stars are used.

Also in this commit: Fixed a few problems due to the last
commit introducing init/checks.F90. There are still problems
remaining. The code does not compile at the moment.

eig-file/data IO is broken and hence the version is not useful yet.

The problem was that in certain situations the origin was identified
as a corner point of the IBZ while it actually was not. It is not a
corner point if less than 3 faces of the IBZ feature this point.

removed: weight, natd, nkpts,nkptd

At some places input files for the input file generator lead
to "output conversion errors" in the debug version of inpgen, i.e.,
instead of numbers something like *** was written out. This happened
if the input contained too many atoms or the unit cell was too
long in one of the dimensions. I added a few digits to the output
at the respective places to overcome this problem.