GitLab

   ...vXC%pw_w was not initialized.

   + some code beautification

...for non-spinpolarized systems.

The problem was that the 2nd dimension of vCoul%pw was set to 2 by the assignment
modified in this commit. This lead to an MPI broadcasting problem as it was only
done for rank 0. At some point one should check whether we actually need more
than the 2 spin dimensions for this potential contribution.

Note: This seems to have introduced some bugs. ...to be corrected soon.

The bug was introduced in commit 62285e99.

Thanks to Patrick for pointing out that there was a bug.

I don't know whether there was a problem due to the absence of this code.

Note: Two changes have been done in global/types.F90:

   1. MERGE(jsp,4,l_noco) -> MERGE(4,jsp,l_noco)
      (I think the new code is correcter. This change is required)

   2. Some dimension variable was replaced by stars%ng2.
      (Maybe this is not required and maybe the previous variable was more correct.)

...also in this commit: global/constants.f -> global/constants.f90

Also in this commit: Removal of mpi/mpi_bc_pot.F90 as it is replaced by mpi/mpi_bc_potden.F90

-removing of variable icorr, use of member-functions instead
-removal of icorrkeys module
-removal of hybridmix module
-cleanup at several places

(The bugs were somehow introduced due to the inclusion of the hybrid code.)

At the moment this does not seem to be important as the final result
of vgen seems to be originating from irank 0 only. However, valgrind
complained that some jump in vgen->vmts->ingr (line 191) is undefined
because an initialization is missing for all iranks != 0.

Bugfixes, put swapped some variables between hybrid/hybdat datatype, moved files from xc-pot to hybrid