GitLab

...it is used with the command line option -last_extra.

The preconditioner already improves the convergence of Cu and Fe files, but the starting distance is higher than for the older fleur version and tests run up to test 7 only (does not fail, but hangs).

in potden: introduce subroutines SpinsToChargeAndMagnetisation and ChargeAndMagnetisationToSpins
Writing preconditioned quantities to files is now substituted by passing types. This changes a lot.

...in optional/pldngen.f90 this has to be strongly polished.

Note: This seems to have introduced some bugs. ...to be corrected soon.

Replace broyden2 by broyden agein until the problem with continuous restart are understood and solved

This implies the reduction of required metric calls in the broyden code path
from 4 to 2. This is now equivalent to the number of metric calls in the
old broyden code path.

This is not yet fully functional and not yet activated in the code. To activate it
the broyden call in "mix" has to be replaced by a broyden2 call.

...this surely is not yet the final version.

..also in this commit: slight cleanup in mix/metric.f90

Note: Also in this commit:

1. Changed test values in NiO_ldauXML test since now the broyden files get deleted
   when a new density matrix is generated
2. The NiO_ldau test should not work any more since linear mixing for the density
   matrix is removed for the old inp file. (It is not specified in the n_mmp_mat
   file any more)

I don't know whether there was a problem due to the absence of this code.

Note: The NiO_ldau and NiO_ldauXML tests had to be adapted to this new
behavior of the code. The new behavior is reasonable.

Up to now this is only a partial solution. There is still reading
of the n_mmp_mat file in the SCF loop to read in the optional mixing
parameters.

I couldn't identify the original bug so I did some major changes and
now everything is different.

There still is a problem but it is different now.

Note: This seems to break the LDA+U part. I commit it at this point
to get it on a computer with Valgrind available.

-removing of variable icorr, use of member-functions instead
-removal of icorrkeys module
-removal of hybridmix module
-cleanup at several places