DetectorScene improvements + fixed integration regions
- Refactored
DetectorScene
extensively: removed unused members broke up over-nested functions, moved functionality into different classes. - Move all methods that generate
PeakCollection
-related graphics from DetectorScene to new classPeakCollectionGraphics
- Move all methods that generate
DataSet
-related graphics from DetectorScene to new classDetectorSceneGraphics
- Removed
MaskHandler
class since lifetime of mask graphic objects was unpredictable and causing segfaults. - Fixed issues with masks, graphical masks were not reflected correctly in core algorithms.
- Added separate parameters for fixed integration regions to avoid confusion
- Removed
RegionType::FixedSphere
, I can't imagine it ever being useful. - No longer store pointers to subclassed
QGraphicsItem
s when they are in theDetectorScene
, since their lifetimes are too unpredictable. - Handle failure to generate graphical items for
DetectorScene
withstd::optional
. - Greatly reduced number of
DetectorScene
parameters, added many to newDetectorSceneParams
header. - New base class for
BoxMaskItem
andEllipseMaskItem
,MaskItem
, to facilitate adding/removing them from scene. - Removed all code for generating graphics from
Subframe
classes, move toPeakCollectionGraphics
/DataSetGraphics
. - Added name of
DataSet
associated with aPeakCollection
to relevantSubframeHome
table. - Fixed bug in
MaskImporter
(arguments ofAABB
, lower and upper bounds were reversed).
Resolves #582 (closed), #581 (closed), #228 (closed), #578 (closed) and #583 (closed)
Edited by Zamaan Raza